fbrinker/docker-tileboard-OUTDATED
fbrinker/docker-tileboard-OUTDATED
Archived
1
1
Fork 1
Code Issues 1 Pull Requests Releases Activity

feature: nightly and dev images #5

Merged
fbrinker merged 10 commits from akloeckner/fbrinker-tileboard:feat-nightly into master 2021-05-10 19:23:53 +00:00
Conversation 8 Commits 10 Files Changed 4 +93 -1
akloeckner commented 2021-05-10 09:59:30 +00:00
Contributor
Copy Link

So, here we go with a PR for the nightly images. They will need to have a nightly (at least) run of the pipeline.

I have also included a script and modifications to drone.yml, which I believe should serve well as a check-for-changes. But I have no way to check this in your drone environment. And I have not (yet) checked it locally, either. I just copied things over from my GitHub setup. (Update: The script works for me locally.)

Could you have a look and let me know, what needs to be changed from your point of view?

(I don't know Gitea too well... If there's an option to let you write into this feature branch, I'll enable it.)

fixes #4

So, here we go with a PR for the nightly images. **They will need to have a nightly (at least) run of the pipeline.** I have also included a script and modifications to `drone.yml`, which I believe should serve well as a check-for-changes. But I have no way to check this in your drone environment. ~~And I have not (yet) checked it locally, either. I just copied things over from my GitHub setup.~~ (Update: The script works for me locally.) Could you have a look and let me know, what needs to be changed from your point of view? (I don't know Gitea too well... If there's an option to let you write into this feature branch, I'll enable it.) fixes #4
akloeckner added 5 commits 2021-05-10 09:59:32 +00:00 
* TODO: Do not run nightly builds, if no changes in `master` branch.
This can abort the whole pipeline, because releases also show up as a commit.
akloeckner added 1 commit 2021-05-10 10:33:27 +00:00
akloeckner added 1 commit 2021-05-10 12:45:41 +00:00
fbrinker commented 2021-05-10 13:58:51 +00:00
Owner
Copy Link

Thank you :)
I hope I can look into this this evening. Otherwise it will be tomorrow evening :)

Thank you :) I hope I can look into this this evening. Otherwise it will be tomorrow evening :)
akloeckner commented 2021-05-10 15:27:11 +00:00
Author
Contributor
Copy Link

No hurry. I'm just curious right now, so I'm playing around. :-)

I also just added #6. Probably, this needs to be fixed before we can merge the present PR. I kept it separate in order for you to inspect more easily. I can also merge the fix of build.sh into the branch for the nightly feature, if you prefer.

No hurry. I'm just curious right now, so I'm playing around. :-) I also just added #6. Probably, this needs to be fixed before we can merge the present PR. I kept it separate in order for you to inspect more easily. I can also merge the fix of `build.sh` into the branch for the `nightly` feature, if you prefer.
fbrinker added 3 commits 2021-05-10 16:55:24 +00:00
fbrinker commented 2021-05-10 17:04:10 +00:00
Owner
Copy Link

Excellent work. I see you took a look into the drone.io Docker plugin :)

I could just check out your fork and push the changes :)
I've prepared the master for a Production pipeline and added a sperate Development pipeline in your branch. This way we have 2 "somewhat" seperated build jobs so if one fails, the other one can continue its process.

Please review my changes and after that, I'm willing to merge it and give it a try

The only point I'm thinking about is the commit-check script. If my push-hook would work *cough* we could build a nightly container on each push(merge) into the tileboard master and it would be always up to date. But since it's not reliable right now..... we should start with scheduled builds ^^

Excellent work. I see you took a look into the drone.io Docker plugin :) I could just check out your fork and push the changes :) I've prepared the master for a Production pipeline and added a sperate Development pipeline in your branch. This way we have 2 "somewhat" seperated build jobs so if one fails, the other one can continue its process. Please review my changes and after that, I'm willing to merge it and give it a try ![](https://media1.tenor.com/images/d774468a528b9aab5b9773e74a7be2b4/tenor.gif?itemid=10121476) The only point I'm thinking about is the commit-check script. If my push-hook would work \*cough\* we could build a nightly container on each push(merge) into the tileboard master and it would be always up to date. But since it's not reliable right now..... we should start with scheduled builds ^^
fbrinker commented 2021-05-10 17:42:18 +00:00
Owner
Copy Link

Hmm I am going to use Github as the main platform for this project in the future.
Still with my drone.io setup but I didn't expect anyone to be interested in maintaining this with me :D

So Github wont me a mirror anymore.
If you want, you can create a new PR on Github at https://github.com/fbrinker/docker-tileboard

And push these changes there again if you want. So you will be listed as contributor.

This Gitea instance is mostly for my private projects and I feel a little bit bad if you add nice features and don't even appear @ the Github mirror :(

Maybe you don't care, but credit where credit is due :)

I still have to change a few settings and links but I would wait until you decide where you want this PR to be merged. But you earn your activity showing up @Github ;)

Hmm I am going to use Github as the main platform for this project in the future. Still with my drone.io setup but I didn't expect anyone to be interested in maintaining this with me :D So Github wont me a mirror anymore. If you want, you can create a new PR on Github at https://github.com/fbrinker/docker-tileboard And push these changes there again if you want. So you will be listed as contributor. This Gitea instance is mostly for my private projects and I feel a little bit bad if you add nice features and don't even appear @ the Github mirror :( Maybe you don't care, but credit where credit is due :) I still have to change a few settings and links but I would wait until you decide where you want this PR to be merged. But you earn your activity showing up @Github ;)
akloeckner commented 2021-05-10 18:44:40 +00:00
Author
Contributor
Copy Link

I just checked, and I do show up as contributor already. (GitHub seems to parse all history.) So, for me, it would be more convenient to have this merged here, still. Next PR would go to the GitHub repository.

I also checked your changes and agree with them.

As to the push hook, I believe there is no way to trigger a build in your repo on each push to the official repo, unless the maintainers there authorize you with their repository (which would be worth a try asking for). Until then, simply running on a schedule should also do most of the trick. After all there's not that many releases per day. ;-)

So, I'd be good to merge!

PS: Yes, I looked into drone.io. :-) I don't like to propose half-baked solutions. And as I said, I was curious...

I just checked, and I *do* show up as contributor already. (GitHub seems to parse all history.) So, for me, it would be more convenient to have this merged here, still. Next PR would go to the GitHub repository. I also checked your changes and agree with them. As to the push hook, I believe there is no way to trigger a build in your repo on each push to the official repo, unless the maintainers there authorize you with their repository (which would be worth a try asking for). Until then, simply running on a schedule should also do most of the trick. After all there's not *that* many releases per day. ;-) So, I'd be good to merge! PS: Yes, I looked into drone.io. :-) I don't like to propose half-baked solutions. And as I said, I was curious...
akloeckner commented 2021-05-10 18:54:33 +00:00
Author
Contributor
Copy Link

PPS: If you don't mind, you could try to squash merge this PR. this way, we find out, how it's attributed on GitHub later. ;-)

PPS: If you don't mind, you could try to squash merge this PR. this way, we find out, how it's attributed on GitHub later. ;-)
fbrinker commented 2021-05-10 19:23:15 +00:00
Owner
Copy Link

I would bet a squash is in my name and your commits are lost due to the squash. But we can give it a try.

And yes you are a contributor already. Didn't notice that, nice :)
But the activity is missing in your stream

I would bet a squash is in my name and your commits are lost due to the squash. But we can give it a try. And yes you are a contributor already. Didn't notice that, nice :) But the activity is missing in your stream
fbrinker merged commit 6595011075 into master 2021-05-10 19:23:53 +00:00
fbrinker commented 2021-05-10 19:24:38 +00:00
Owner
Copy Link

Okay I didn't expect this result. Gitea noted me as a "Co-authored-by" :D
That's nice ^^

Okay I didn't expect this result. Gitea noted me as a "Co-authored-by" :D That's nice ^^
🎉 1 😆 1
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fbrinker/docker-tileboard-OUTDATED#5
No description provided.
Delete Branch "akloeckner/fbrinker-tileboard:feat-nightly"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?