From 634f7b5c6d0603cbe7e800b58a685286e51bb535 Mon Sep 17 00:00:00 2001
From: Florian Brinker <mail+git@f-brinker.de>
Date: Sat, 20 Mar 2021 16:03:01 +0100
Subject: [PATCH] Fix ShowDetails not working properly

---
 AchievementInfoApplication.lua | 7 ++++++-
 CHANGELOG.md                   | 3 +++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/AchievementInfoApplication.lua b/AchievementInfoApplication.lua
index 00b925d..656267a 100644
--- a/AchievementInfoApplication.lua
+++ b/AchievementInfoApplication.lua
@@ -73,7 +73,12 @@ function AchievementInfo.onAchievementUpdated(_, achId)
         tmpOutput = tmpOutput .. AchievementInfo.clrCriteriaComplete .. numRequired .. "|r"
         tmpOutput = tmpOutput .. AchievementInfo.clrDefault
 
-        if AchievementInfo.settingGet("genShowOpenDetailsOnly") == true and numCompleted ~= numRequired then
+        if AchievementInfo.settingGet("genShowOpenDetailsOnly") == true then
+            if numCompleted ~= numRequired then
+                detailOutput[detailOutputCount] = tmpOutput
+                detailOutputCount = detailOutputCount + 1
+            end
+        else
             detailOutput[detailOutputCount] = tmpOutput
             detailOutputCount = detailOutputCount + 1
         end
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 55f7e8a..87e02a1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,8 @@
 #### Notable Changes
 
+##### Release 4.5
+* Fixed "ShowDetails" option working only in combination with "ShowOpenDetailsOnly"
+
 ##### Release 4.3
 * Fixed an error with gendered achievement descriptions