From 7ea5ec71f5c2c837dd740c5f720481de6a54b23a Mon Sep 17 00:00:00 2001
From: Florian Brinker <mail+gitlab@f-brinker.de>
Date: Wed, 23 Oct 2019 22:24:30 +0200
Subject: [PATCH] Add LUA linting

---
 .drone.yml                | 14 ++++++++++----
 AchievementInfoCommon.lua |  2 +-
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/.drone.yml b/.drone.yml
index 3ee8711..1bfbca7 100644
--- a/.drone.yml
+++ b/.drone.yml
@@ -11,9 +11,15 @@ steps:
   commands:
   - git clone https://git.f-brinker.de/fbrinker/elderscrolls-addon-achievementInfo.git sources
   - cd sources && git checkout $DRONE_COMMIT
-  when:
-    event: 
-      - tag
+
+- name: lint
+  image: alpine
+  commands:
+    - apk update
+    - apk add --no-cache build-base curl unzip
+    - apk add --no-cache lua5.1 lua5.1-dev luarocks5.1
+    - luarocks-5.1 install luacheck
+    - luacheck sources/*.lua --compat --allow-defined --no-unused-args --no-max-line-length
 
 - name: build
   image: alpine
@@ -25,7 +31,7 @@ steps:
     # Set Version and AddonVersion
     - export VERSION=$DRONE_TAG
     - export ADDON_VERSION=$(echo $DRONE_TAG | sed -E 's/(0|)\.//g')
-    - sed -i "s/%VERSION%/$VERSION/g" sources/AchievementInfoCommon.lua
+    - sed -i "s/\"%VERSION%\"/$VERSION/g" sources/AchievementInfoCommon.lua
     - sed -i "s/%VERSION%/$VERSION/g" sources/AchievementInfo.txt
     - sed -i "s/%ADDON_VERSION%/$ADDON_VERSION/g" sources/AchievementInfo.txt
     # Rename and zip
diff --git a/AchievementInfoCommon.lua b/AchievementInfoCommon.lua
index 9f9d3c2..db0e92f 100644
--- a/AchievementInfoCommon.lua
+++ b/AchievementInfoCommon.lua
@@ -8,7 +8,7 @@
 AchievementInfo             = {}
 AchievementInfo.name        = "AchievementInfo"
 AchievementInfo.author      = "Asto, @Astarax"
-AchievementInfo.version     = %VERSION%
+AchievementInfo.version     = "%VERSION%"
 AchievementInfo.savedVars   = nil
 AchievementInfo.LangStore   = {}