fbrinker/docker-tileboard-OUTDATED
fbrinker
/
docker-tileboard-OUTDATED
Archived
1
1
Fork 1
Code Issues 1 Pull Requests Releases Activity

fix: make build.sh not rely on tag being latest #6

Merged
fbrinker merged 2 commits from akloeckner/fbrinker-tileboard:feat-repos into master 2021-05-10 16:11:03 +00:00
Conversation 1 Commits 2 Files Changed 1 +21 -16
akloeckner commented 2021-05-10 15:24:00 +00:00
Contributor
Copy Link

This introduces:

  • an explicit check for the existence of the latest version tag
  • more verbose output
    • This was just for debugging actually, but I believe it might help in the future.
  • input parameters to the build.sh script
    • This allows for using the script also from other repos. I'd like to keep trying things without having to ask you for checking in Drone.io...

This is probably related to #5, because if we introcude the nightly tag, the current check might fail.

This introduces: * an explicit check for the existence of the latest version tag * This way, we don't need to bother to have `nightly` or `dev` tags in place. The new check works by `curl` failing, if the target tag does not exist. Source: https://stackoverflow.com/questions/32113330/check-if-imagetag-combination-already-exists-on-docker-hub * more verbose output * This was just for debugging actually, but I believe it might help in the future. * input parameters to the `build.sh` script * This allows for using the script also from other repos. I'd like to keep trying things without having to ask you for checking in Drone.io... This is probably related to #5, because if we introcude the `nightly` tag, the current check might fail.
akloeckner added 1 commit 2021-05-10 15:24:02 +00:00
6aec325301 fix: make build.sh not rely on tag being latest 
This introduces:
* an explicit check for the existence of the latest version tag
  * This way, we don't need to bother to have `nightly` or `dev` tags in place. The new check works by `curl` failing, if the target tag does not exist.
* more verbose output
  * This was just for debugging actually, but I believe it might help in the future.
* input parameters to the `build.sh` script
  * This allows for using the script also from other repos. I'd like to keep trying things without having to ask you for checking in Drone.io...
fbrinker added 1 commit 2021-05-10 16:10:27 +00:00
fbrinker merged commit 9aaa9acca9 into master 2021-05-10 16:11:03 +00:00
fbrinker commented 2021-05-10 16:13:13 +00:00
Owner
Copy Link
28	Latest release is: 2.6.0.
29	Nothing to do. Latest release tag already exists.

👍 :)
``` 28 Latest release is: 2.6.0. 29 Nothing to do. Latest release tag already exists. 👍 :)
🎉 1
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fbrinker/docker-tileboard-OUTDATED#6
No description provided.
Delete Branch "akloeckner/fbrinker-tileboard:feat-repos"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?