Fix ShowDetails not working properly

2021-03-20 16:03:01 +01:00 · 2021-03-20 16:03:01 +01:00 · 634f7b5c6d
commit 634f7b5c6d
parent affde86fa9
2 changed files with 9 additions and 1 deletions
--- a/AchievementInfoApplication.lua
+++ b/AchievementInfoApplication.lua
@ -73,7 +73,12 @@ function AchievementInfo.onAchievementUpdated(_, achId)
        tmpOutput = tmpOutput .. AchievementInfo.clrCriteriaComplete .. numRequired .. "|r"
        tmpOutput = tmpOutput .. AchievementInfo.clrDefault

-        if AchievementInfo.settingGet("genShowOpenDetailsOnly") == true and numCompleted ~= numRequired then
+        if AchievementInfo.settingGet("genShowOpenDetailsOnly") == true then
+            if numCompleted ~= numRequired then
+                detailOutput[detailOutputCount] = tmpOutput
+                detailOutputCount = detailOutputCount + 1
+            end
+        else
            detailOutput[detailOutputCount] = tmpOutput
            detailOutputCount = detailOutputCount + 1
        end
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@ -1,5 +1,8 @@
 #### Notable Changes

+##### Release 4.5
+* Fixed "ShowDetails" option working only in combination with "ShowOpenDetailsOnly"
+
 ##### Release 4.3
 * Fixed an error with gendered achievement descriptions