Fix ShowDetails not working properly

New Api Version
Add Download and Favorites Badge
2021-03-20 16:03:01 +01:00 · 2021-03-12 18:01:08 +01:00 · 2020-11-02 21:53:06 +00:00 · 2020-11-02 22:10:33 +01:00 · 2020-11-02 21:08:29 +00:00 · 2020-11-02 21:53:39 +01:00
--- a/.luacheckrc
+++ b/.luacheckrc
@@ -19,5 +19,6 @@ read_globals = {
    "EVENT_MANAGER",
    "LINK_STYLE_BRACKET",
    "zo_callLater",
+    "zo_strformat",
    "ZO_SavedVars",
 }
--- a/AchievementInfo.txt
+++ b/AchievementInfo.txt
@@ -5,7 +5,7 @@
 ## Author: |c87B7CCAsto|r, @Astarax
 ## Contact: mail@coded-with-heart.com

-## APIVersion: 100032
+## APIVersion: 100034
 ## SavedVariables: ACHIEVEMENT_INFO_DB ACHIEVEMENT_INFO_DB_USE_AW

 ## DependsOn: LibAddonMenu-2.0
--- a/AchievementInfoApplication.lua
+++ b/AchievementInfoApplication.lua
@@ -67,13 +67,18 @@ function AchievementInfo.onAchievementUpdated(_, achId)
            tmpOutput = tmpOutput .. ", "
        end

-        tmpOutput = tmpOutput .. description .. " "
+        tmpOutput = tmpOutput .. zo_strformat("<<1>>", description) .. " "
        tmpOutput = tmpOutput .. AchievementInfo.calcCriteriaColor(numCompleted, numRequired) .. numCompleted .. "|r"
        tmpOutput = tmpOutput .. AchievementInfo.clrDefault .. "/" .. "|r"
        tmpOutput = tmpOutput .. AchievementInfo.clrCriteriaComplete .. numRequired .. "|r"
        tmpOutput = tmpOutput .. AchievementInfo.clrDefault

-        if AchievementInfo.settingGet("genShowOpenDetailsOnly") == true and numCompleted ~= numRequired then
+        if AchievementInfo.settingGet("genShowOpenDetailsOnly") == true then
+            if numCompleted ~= numRequired then
+                detailOutput[detailOutputCount] = tmpOutput
+                detailOutputCount = detailOutputCount + 1
+            end
+        else
            detailOutput[detailOutputCount] = tmpOutput
            detailOutputCount = detailOutputCount + 1
        end
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,11 @@
 #### Notable Changes

+##### Release 4.5
+* Fixed "ShowDetails" option working only in combination with "ShowOpenDetailsOnly"
+
+##### Release 4.3
+* Fixed an error with gendered achievement descriptions
+
 ##### Release 4.0
 * Added accountwide settings
 * Added an "use accountwide settings" option to the settings of each character
--- a/README.md
+++ b/README.md
@@ -2,6 +2,8 @@

 [![Build Status](https://drone.f-brinker.de/api/badges/fbrinker/elderscrolls-addon-achievementInfo/status.svg)](https://drone.f-brinker.de/fbrinker/elderscrolls-addon-achievementInfo)
 [![Latest Releases](https://badgen.net/badge/releases/latest)](https://git.f-brinker.de/fbrinker/elderscrolls-addon-achievementInfo/releases)
+[![Downloads](https://badgen.net/https/scripts.f-brinker.de/esoui-stats/badge-total.php?cache=1800)](https://www.esoui.com/downloads/info350-AchievementInfo.html)
+[![Favorites](https://badgen.net/https/scripts.f-brinker.de/esoui-stats/badge-fav.php?cache=1800)](https://www.esoui.com/downloads/info350-AchievementInfo.html)

 This is an **The Elderscrolls Online** addon. [See all details and the download @ESOUI](http://www.esoui.com/downloads/info350-AchievementInfo.html#info).
Tekijä	SHA1	Viesti	Päivämäärä
Florian Brinker	634f7b5c6d	Fix ShowDetails not working properly All checks were successful continuous-integration/drone/push Build is passing Details continuous-integration/drone/tag Build is passing Details	2021-03-20 16:03:01 +01:00
Florian Brinker	affde86fa9	New Api Version All checks were successful continuous-integration/drone/push Build is passing Details continuous-integration/drone/tag Build is passing Details	2021-03-12 18:01:08 +01:00
Florian Brinker	53bc660b7c	Add Download and Favorites Badge All checks were successful continuous-integration/drone/push Build is passing Details	2020-11-02 21:53:06 +00:00
Florian Brinker	ec7939be37	Fix Linting for new global method All checks were successful continuous-integration/drone/push Build is passing Details continuous-integration/drone/tag Build is passing Details	2020-11-02 22:10:33 +01:00
Florian Brinker	de1cb88ca8	Fix Typo Some checks failed continuous-integration/drone/push Build is failing Details	2020-11-02 21:08:29 +00:00
Florian Brinker	176a0ccf91	Fix a bug with gendered labels Some checks failed continuous-integration/drone/push Build is failing Details continuous-integration/drone/tag Build is failing Details	2020-11-02 21:53:39 +01:00
Florian Brinker	fde8966292	New Api Version All checks were successful continuous-integration/drone/push Build is passing Details continuous-integration/drone/tag Build is passing Details	2020-11-02 20:23:24 +01:00